Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates verification results so they reflect newly registered mock interactions, aligning VerificationResult behavior with dynamic interaction recording in Mockolate.
Changes:
- Refactors
VerificationResult<T>to store a predicate and recompute matching interactions on eachVerifycall. - Updates verification registration to pass predicates instead of precomputed interaction arrays.
- Adds/updates tests covering verification updates over time and interaction registration notifications.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| Tests/Mockolate.Tests/Verify/VerificationResultExtensionsTests.cs | Updates VerificationResult construction to match the new constructor signature. |
| Tests/Mockolate.Tests/Verify/MockVerifyTests.cs | Adds a test ensuring IVerificationResult reflects interactions added after the result is created. |
| Tests/Mockolate.Tests/ItTests.MatchesTests.cs | Ensures regex timeout is exercised by executing the verification (AtLeastOnce). |
| Tests/Mockolate.Tests/Interactions/MockInteractionsTests.cs | Adds tests for interaction registration and the new notification event. |
| Tests/Mockolate.Api.Tests/Expected/Mockolate_netstandard2.0.txt | Updates expected public API surface (constructor signature + new event). |
| Tests/Mockolate.Api.Tests/Expected/Mockolate_net8.0.txt | Updates expected public API surface (constructor signature + new event). |
| Tests/Mockolate.Api.Tests/Expected/Mockolate_net10.0.txt | Updates expected public API surface (constructor signature + new event). |
| Source/Mockolate/Verify/VerificationResult.cs | Implements predicate-based matching and recomputation on Verify. |
| Source/Mockolate/MockRegistration.Verify.cs | Switches verification result creation to pass predicates instead of snapshots. |
| Source/Mockolate/Interactions/MockInteractions.cs | Adds an InteractionAdded notification and raises it when registering interactions. |
🚀 Benchmark ResultsDetails
|
|
vbreuss
deleted the
topic/update-verification-result-with-background-interactions
branch
|
This is addressed in release v1.5.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates verification results so they reflect newly registered mock interactions, aligning
VerificationResultbehavior with dynamic interaction recording in Mockolate.Key Changes:
VerificationResult<T>to store a predicate and recompute matching interactions on eachVerifycall..Within(TimeSpan timeout)when verifing interactions #494